Fix linting issues

Signed-off-by: Dom Del Nano <[email protected]>
pixie-io · Aug 16, 2024 · 8c4f275 · 8c4f275
1 parent ebd287b
commit 8c4f275
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 7 deletions.
diff --git a/src/stirling/obj_tools/BUILD.bazel b/src/stirling/obj_tools/BUILD.bazel
@@ -53,7 +53,7 @@ pl_cc_test(
  "//src/stirling/obj_tools/testdata/cc:test_exe_debug_target",
  "//src/stirling/obj_tools/testdata/cc:test_exe_debuglink_target",
  "//src/stirling/obj_tools/testdata/go:test_go_1_19_binary",
- "//src/stirling/obj_tools/testdata/go:test_go_1_19_nm_output"
+ "//src/stirling/obj_tools/testdata/go:test_go_1_19_nm_output",
  ],
  deps = [
  ":cc_library",

diff --git a/src/stirling/obj_tools/elf_reader_test.cc b/src/stirling/obj_tools/elf_reader_test.cc
@@ -89,7 +89,8 @@ StatusOr<Section> ObjdumpSectionNameToAddr(const std::string& path,
  return section;
 }
 
-StatusOr<int64_t> NmSymbolNameToAddr(const std::string& nm_output_path, const std::string& symbol_name) {
+StatusOr<int64_t> NmSymbolNameToAddr(const std::string& nm_output_path,
+ const std::string& symbol_name) {
  // Extract the address from nm as the gold standard.
  int64_t symbol_addr = -1;
  PX_ASSIGN_OR_RETURN(auto nm_out, px::ReadFileToString(nm_output_path));
@@ -310,7 +311,8 @@ TEST(ElfReaderTest, GolangAppRuntimeBuildVersion) {
  elf_reader->SearchTheOnlySymbol("runtime.buildVersion"));
 // Coverage build might alter the resultant binary.
 #ifndef PL_COVERAGE
- ASSERT_OK_AND_ASSIGN(auto expected_addr, NmSymbolNameToAddr(kGoBinNmOutput, "runtime.buildVersion"));
+ ASSERT_OK_AND_ASSIGN(auto expected_addr,
+ NmSymbolNameToAddr(kGoBinNmOutput, "runtime.buildVersion"));
  EXPECT_EQ(symbol.address, expected_addr);
 #endif
  EXPECT_EQ(symbol.size, 16) << "Symbol table entry size should be 16";

diff --git a/src/stirling/obj_tools/testdata/cc/BUILD.bazel b/src/stirling/obj_tools/testdata/cc/BUILD.bazel
@@ -53,8 +53,8 @@ cc_library(
  name = "test_exe_fixture",
  hdrs = ["test_exe_fixture.h"],
  data = [
- ":test_exe",
- ":test_exe_nm_output",
+  ":test_exe",
+  ":test_exe_nm_output",
  ],
  deps = ["//src/common/exec:cc_library"],
 )

diff --git a/src/stirling/obj_tools/testdata/cc/test_exe_fixture.h b/src/stirling/obj_tools/testdata/cc/test_exe_fixture.h
@@ -31,7 +31,8 @@ namespace obj_tools {
 class TestExeFixture {
  public:
  static constexpr char kTestExePath[] = "src/stirling/obj_tools/testdata/cc/test_exe_/test_exe";
- static constexpr char kTestExeNmOutputPath[] = "src/stirling/obj_tools/testdata/cc/test_exe_nm_output";
+ static constexpr char kTestExeNmOutputPath[] =
+ "src/stirling/obj_tools/testdata/cc/test_exe_nm_output";
 
  const std::filesystem::path& Path() const { return test_exe_path_; }
  const std::filesystem::path& NmOutputPath() const { return test_exe_nm_output_path_; }
@@ -43,7 +44,8 @@ class TestExeFixture {
 
  private:
  const std::filesystem::path test_exe_path_ = testing::BazelRunfilePath(kTestExePath);
- const std::filesystem::path test_exe_nm_output_path_ = testing::BazelRunfilePath(kTestExeNmOutputPath);
+ const std::filesystem::path test_exe_nm_output_path_ =
+ testing::BazelRunfilePath(kTestExeNmOutputPath);
 };
 
 } // namespace obj_tools