Add support for tolerations in operator #1648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benkilimnik
temporarily deployed
to
pr-actions-approval
GitHub Actions
Inactive
benkilimnik
force-pushed
the
tolerations-px-deploy
branch
from
d634516
to
4cb3372
Compare
benkilimnik
temporarily deployed
to
pr-actions-approval
GitHub Actions
Inactive
benkilimnik
force-pushed
the
tolerations-px-deploy
branch
from
4cb3372
to
1955707
Compare
benkilimnik
temporarily deployed
to
pr-actions-approval
GitHub Actions
Inactive
aimichelle
reviewed
Aug 4, 2023
|
Looks like it is failing |
benkilimnik
force-pushed
the
tolerations-px-deploy
branch
from
1955707
to
ebfda16
Compare
benkilimnik
temporarily deployed
to
pr-actions-approval
GitHub Actions
Inactive
Signed-off-by: Benjamin Kilimnik <[email protected]>
benkilimnik
force-pushed
the
tolerations-px-deploy
branch
from
ebfda16
to
d271707
Compare
benkilimnik
temporarily deployed
to
pr-actions-approval
GitHub Actions
Inactive
aimichelle
approved these changes
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Adds support for tolerations to enable users to deploy PEMs to nodes that have taints through the CLI.
Relevant Issues: #598
Type of change: /kind feature
Test Plan: Used skaffold to deploy an unreleased version of the operator. Verified that tolerations parameter actually gets passed through to the pod spec.