Ability to add tolerations to PEMs #598
Comments
aimichelle
added
kind/feature
|
Hi @aimichelle I'm newbie and I'm interested in this issue. Can you tell a little bit about how you are passing toleration parameters in the following command because setting nodeSelector will not tolerate the taint, it will only match the labels of node and scheduler will try to schedule the pod on that node if the labels matches but it will not be scheduled if |
|
Hey @yousaf-aftab ! The patching mechanism is essentially performing the equivalent of a kubectl patch. I think something similar to what was done for nodeSelector (example changes here #362) would work really well for the tolerations! Let me know if you have any questions after going through that PR. |
Summary: Adds support for tolerations to enable users to deploy PEMs to nodes that have taints through helm. Relevant Issues: #598 Type of change: /kind feature Test Plan: ran `helm install` using the [previous operator helm chart ](https://github.com/pixie-io/pixie/releases/download/release%2Foperator%2Fv0.1.4/pixie-operator-chart-0.1.4.tgz) with these changes and verified that tolerations appear in the CRD. Signed-off-by: Benjamin Kilimnik <[email protected]>
Summary: Adds support for tolerations to enable users to deploy PEMs to nodes that have taints through the CLI. Relevant Issues: #598 Type of change: /kind feature Test Plan: Used skaffold to deploy an unreleased version of the operator. Verified that tolerations parameter actually gets passed through to the pod spec. Signed-off-by: Benjamin Kilimnik <[email protected]>
|
Closed thanks to @benkilimnik 's work on #1649 and #1648! |
Is your feature request related to a problem? Please describe.
Users would like to easily add tolerations in order to deploy PEMs to nodes that have taints.
This can be done by manually updating the resources to include the tolerations, however these changes aren't sticky after auto-updates.
You can currently use patches to add the toleration or nodeSelector to various resources, but this is prone to syntax errors. For example, setting a nodeSelector to the PEMs using helm:
Describe the solution you'd like
Users should be able to easily specify tolerations for their PEMs through the CLI and Helm Chart. This should look similarly to how tolerations are specified on K8s resources.
The text was updated successfully, but these errors were encountered: