Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix macOS Runner when Meson is Already Installed, and Add macOS 15 #1253

Merged
merged 6 commits into from
Oct 14, 2024

Commits on Oct 13, 2024

  1. Fix: Use --overwrite when installing Meson for macOS Runner

    Otherwise, we get:
        Error: The `brew link` step did not complete successfully
    when brew is trying to upgrade Python3 for meson's use upon the
    command "brew install meson" in the github runner.
    dgreatwood committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    9db5858 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    bb60516 View commit details
    Browse the repository at this point in the history
  3. Fix: Check meson not already installed before installing with brew

    Otherwise github runner for macOS can generate an error attempting to
    upgrade Python.
    dgreatwood committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    a2a34e0 View commit details
    Browse the repository at this point in the history
  4. Fix: Update version.txt

    dgreatwood committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    65201bf View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2024

  1. Experiment: Try not doing brew update

    In macOS runner for macOS-13, brew update may be causing it to attempt
    to install newer version of Python with meson (newer than the one
    installed in the github macOS image), but the new Python install
    fails, blocked by the version of Python3 that's already installed.
    dgreatwood committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    ee4738f View commit details
    Browse the repository at this point in the history
  2. Fix: Avoid Doing "brew update" for macOS Runner

    We avoid doing "brew update" - the brew formulas that are preinstalled
    on the github runner image are likely consistent with the
    pre-installed software on the image. If we do "brew upate", and then
    install something new with brew (specifically meson), and the
    "something new" depends on pre-installed software on the image, and
    there are new versions of the pre-installed software revealed by doing
    "brew update", then when we install the "something new" brew may try
    and also install a new version of the pre-installed software on which
    the "something new" depends, but that attempt to install a new version
    of the pre-installed software can fail as a result of being blocked by
    the software that is already installed.
    
    Also, removed this branch from list of branches to run macos.yaml.
    dgreatwood committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    ffb4e48 View commit details
    Browse the repository at this point in the history