Fix macOS Runner when Meson is Already Installed, and Add macOS 15 #1253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, we get:
Error: The `brew link` step did not complete successfully
when brew is trying to upgrade Python3 for meson's use upon the
command "brew install meson" in the github runner.
Otherwise github runner for macOS can generate an error attempting to upgrade Python.
|
Looks fine to me @dgreatwood. Good work. If nothing (new) breaks in CI, I'll merge after its done. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1253 +/- ##
==========================================
- Coverage 76.29% 76.18% -0.12%
==========================================
Files 58 57 -1
Lines 10027 9821 -206
==========================================
- Hits 7650 7482 -168
+ Misses 2377 2339 -38 ☔ View full report in Codecov by Sentry. |
|
Looks like macOS-12, 14 and 15 are OK, but still a problem with 13. I'll
take another look.
…On Sun, Oct 13, 2024 at 3:28 PM Kip ***@***.***> wrote:
Looks fine to me @dgreatwood <https://github.com/dgreatwood>. Good work.
If nothing (new) breaks in CI, I'll merge after its done.
—
Reply to this email directly, view it on GitHub
<#1253 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFMA227CHTTY73DGI67VX3Z3LXXXAVCNFSM6AAAAABP32566SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBZGIYTANJUHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
NOTICE: This email and its attachments may contain privileged and
confidential information, only for the viewing and use of the intended
recipient. If you are not the intended recipient, you are hereby notified
that any disclosure, copying, distribution, acting upon, or use of the
information contained in this email and its attachments is strictly
prohibited and that this email and its attachments must be immediately
returned to the sender and deleted from your system. If you received this
email erroneously, please notify the sender immediately. Xage Security,
Inc. and its affiliates will never request personal information (e.g.,
passwords, Social Security numbers) via email. Report suspicious emails to
***@***.*** ***@***.***>
|
In macOS runner for macOS-13, brew update may be causing it to attempt to install newer version of Python with meson (newer than the one installed in the github macOS image), but the new Python install fails, blocked by the version of Python3 that's already installed.
We avoid doing "brew update" - the brew formulas that are preinstalled on the github runner image are likely consistent with the pre-installed software on the image. If we do "brew upate", and then install something new with brew (specifically meson), and the "something new" depends on pre-installed software on the image, and there are new versions of the pre-installed software revealed by doing "brew update", then when we install the "something new" brew may try and also install a new version of the pre-installed software on which the "something new" depends, but that attempt to install a new version of the pre-installed software can fail as a result of being blocked by the software that is already installed. Also, removed this branch from list of branches to run macos.yaml.
|
Fixed now for macOS-13 also; branch updated.
On Sun, Oct 13, 2024 at 3:45 PM Duncan Greatwood ***@***.***>
wrote:
… Looks like macOS-12, 14 and 15 are OK, but still a problem with 13. I'll
take another look.
On Sun, Oct 13, 2024 at 3:28 PM Kip ***@***.***> wrote:
> Looks fine to me @dgreatwood <https://github.com/dgreatwood>. Good work.
> If nothing (new) breaks in CI, I'll merge after its done.
>
> —
> Reply to this email directly, view it on GitHub
> <#1253 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAFMA227CHTTY73DGI67VX3Z3LXXXAVCNFSM6AAAAABP32566SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBZGIYTANJUHA>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
--
NOTICE: This email and its attachments may contain privileged and
confidential information, only for the viewing and use of the intended
recipient. If you are not the intended recipient, you are hereby notified
that any disclosure, copying, distribution, acting upon, or use of the
information contained in this email and its attachments is strictly
prohibited and that this email and its attachments must be immediately
returned to the sender and deleted from your system. If you received this
email erroneously, please notify the sender immediately. Xage Security,
Inc. and its affiliates will never request personal information (e.g.,
passwords, Social Security numbers) via email. Report suspicious emails to
***@***.*** ***@***.***>
|
|
Late review, but looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that the github macOS runners now have meson preinstalled.
This was causing an issue when our macos.yaml did:
brew install mesonWe now have macos.yaml check for meson, and install it only if meson is not already present.
Also, added the newly released macOS-15 as one of the OS to test in macos.yaml.