Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.0 #60

Merged
merged 36 commits into from
Sep 9, 2024
Merged

Release 2.0 #60

merged 36 commits into from
Sep 9, 2024

Conversation

dougwilson
Copy link
Contributor

@dougwilson dougwilson commented Oct 14, 2017

This is a tracking issue for release 2.0.

Try the latest beta with npm install [email protected]

Please keep feature requests in their own issues

If you want to make a comment on a particular change, please make the comment in the "Files changed" tab so comments are not lost during a rebase.

List of changes for release:

List of things to refactor:

  • Use standard style

Testing this release

If you want to try out this release, you can install it with the following commands:

$ npm cache clean router
$ npm install pillarjs/router#2.0

Owners/collaborators: please do not merge this PR :)

@wesleytodd
Copy link
Member

Once the other two pending PR's are done I will do the final one "Use standard style". Can we look at setting a date as a goal to get out 2.0 on this?

@dougwilson dougwilson added this to the 2.0 milestone Jul 19, 2018
@edevil
Copy link

edevil commented Sep 10, 2018

@dougwilson @wesleytodd Is there anything I can do to help move this forward?

@markstos
Copy link

I'm looking forward to the new release with promise support.

lib/layer.js Show resolved Hide resolved
@xjamundx
Copy link

xjamundx commented Dec 12, 2021

Would it be useful to explicitly test async functions?

I know there are many places where we test directly returning Promise.reject(). There are at least 2 scenarios I think that would be worth looking at:

For example all of these should be treated in the exact same way:

async function middleware1(req, res, next) {
   await Promise.reject(new Error("ok bye"));
}

async function middleware2(req, res, next) {
   throw new Error("ok bye");
}

function middleware3(req, res, next) {
   return Promise.reject(new Error("ok bye"));
}

function middleware4(req, res, next) {
   throw new Error("ok bye");
}

There are a few ways you can detect async function support if you want to do that, including some of the ones mentioned here:
https://stackoverflow.com/a/46127053/496735

Happy to file a follow on PR with these tests as well.

@hypesystem
Copy link

hypesystem commented Mar 16, 2022

Hey, if there's anything I can help with to move this forward, I would love to contribute, but don't really know how 😄 (been using express since 2014, pretty familiar with how it works, happy to write some code or contribute in any other way).

Is the checklist in the original description accurate, or is there more to do?

@wesleytodd
Copy link
Member

expressjs/express@74beeac

This commit on express is breaking when I try to merge up to 4.19.0 on the 5.x branch. I don't see it associated with any PR or additional context. For now I am going to disable the test in the express side but wanted to flag it here so we could figure out the history and re-enable before landing this.

@wesleytodd
Copy link
Member

wesleytodd commented Mar 20, 2024

expressjs/express@631ada0

This one is also looking to not be ported over and so failing the tests. Same as above, going to disable to get the branches synced up. Then I can port these here, publish a new router prerelease and then port it back to the other branch.

Just going to edit this now that there are more:

expressjs/express@708ac4c

Copy link

socket-security bot commented Aug 23, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] None 0 15 kB linusu
npm/[email protected] filesystem, unsafe Transitive: environment, eval, network +93 5.86 MB ljharb
npm/[email protected] filesystem Transitive: environment +16 1.51 MB mysticatea
npm/[email protected] Transitive: environment, eval, filesystem, shell, unsafe +108 11.6 MB xjamundx
npm/[email protected] None 0 28.7 kB feross
npm/[email protected] None 0 2.96 kB then-bot
npm/[email protected] None 0 30.9 kB blakeembrey
npm/[email protected] None 0 5.66 kB feross

🚮 Removed packages: npm/[email protected]), npm/[email protected])

View full report↗︎

@wesleytodd wesleytodd merged commit 168de1d into master Sep 9, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants