Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add async await syntax support to Router #3600

Closed
wants to merge 1 commit into from

Conversation

logig
Copy link

@logig logig commented Mar 21, 2018

add async await error handle support to Router.

add `async await` error handle support for Router.
@wesleytodd
Copy link
Member

Hey @logig! Thanks for your contribution. I think it might be a bit more complicated than this PR makes it out to be. To get async/await support we need more than just this change, and there has been some work done on this which you might want to check out:

#2259
pillarjs/router#60

Lastly, it would be great if you want to take up this project, but you would want to do it on the router repo linked above, as that is what express@5 will be using.

@logig
Copy link
Author

logig commented Mar 22, 2018

Got it.

@logig logig closed this Mar 22, 2018
@logig logig deleted the patch-1 branch March 22, 2018 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants