Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support searching where value is unknown #75

Merged
merged 3 commits into from
Nov 6, 2023
Merged

feat: support searching where value is unknown #75

merged 3 commits into from
Nov 6, 2023

Commits on Nov 6, 2023

  1. feat: support searching where value is unknown 

    Adds minimal support for 3-valued logic. Formula types support
arbitrarily many extended types with the default (X = never) type,
but parsing and evaluating is currently only well-defined for value
types that extend (boolean | null).

Note that we're using null to represent unknown here in part so that
helpers like

    atom(property, value = true)

can distinguish between being called with an unknown and being called
without providing the default argument.

Fixes #70
    @jamesdabbs
    jamesdabbs committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    b460c5c View commit details
    Browse the repository at this point in the history

  2. fix: formula summary display for unknowns

    @jamesdabbs
    jamesdabbs committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    b33562a View commit details
    Browse the repository at this point in the history

  3. chore: restore test coverage thresholds

    @jamesdabbs
    jamesdabbs committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    5fa1da5 View commit details
    Browse the repository at this point in the history