feat: support searching where value is unknown #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds minimal support for 3-valued logic. Formula types support
arbitrarily many extended types with the default (X = never) type,
but parsing and evaluating is currently only well-defined for value
types that extend (boolean | null).
Note that we're using null to represent unknown here in part so that
helpers like
atom(property, value = true)
can distinguish between being called with an unknown and being called
without providing the default argument.
Fixes #70
Deploying with
|
| Latest commit: |
5fa1da5
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://bc4d01fd.topology.pages.dev |
| Branch Preview URL: | https://3-valued-logic.topology.pages.dev |
jamesdabbs
commented
Nov 6, 2023
Comment on lines
+34
to
+37
| export interface Atom<P, X = never> { | ||
| kind: 'atom' | ||
| property: P | ||
| value: boolean | ||
| value: boolean | X |
There was a problem hiding this comment.
X represents the set of extended (non-boolean) allowed values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds minimal support for 3-valued logic. Formula types support arbitrarily many extended types with the default (X = never) type, but parsing and evaluating is currently only well-defined for value types that extend (boolean | null).
Note that we're using null to represent unknown here in part so that helpers like
can distinguish between being called with an unknown and being called without providing the default argument.
Fixes #70
🔬 Testing Notes
Visiting this search url shows