feat(vscode): share body parsing and external ref logic with core #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the underlying issue that required a `skipLibCheck` in the first place.
defining it as a function means we can simplify the reactivity
Deploying topology with
|
| Latest commit: |
7370c31
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3d123fdd.topology.pages.dev |
| Branch Preview URL: | https://jcd-vscode-parser.topology.pages.dev |
jamesdabbs
force-pushed
the
jcd/vscode-parser
branch
from
03db567
to
3ffa14a
Compare
jamesdabbs
changed the title
and update the VSCode extension to use the body parsing logic in hover previews. Still a few polishing items to do here: - expand internal references to linked names - fix katex styling oddities but this is a reasonable enough start to at least publish as a prerelease version.
jamesdabbs
force-pushed
the
jcd/vscode-parser
branch
from
3ffa14a
to
7370c31
Compare
|
I gave it a spot test just now and didn't run into anything broken. |
This was referenced Jun 17, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the ~first of several changes we'll want to make to push logic that is currently in the viewer or compiler down into the core, so that we can share it between those and the VSCode extension and keep them operating consistently. The goal with this one is getting the parsing toolchain working at all, and at least rendering external links. Internal links have a few complications that can be addressed as a follow-up.
Note that the dependency shuffling here required(?) us to move from
esbuildtowebpack, to get better support for shimming theunifiedecosystem'snode:pathdependencies &c.Review Notes
This PR is (essentially) branched off of #155 and (inessentially) off of #158. The main work here is 3ffa14a, which may be easier to review in isolation. If it'd help, we can pull out some of the other commits.
Testing Notes
This is currently published as a prerelease version (
0.1.18) which you can opt into to test –(See also the Testing Notes in #158)