Misc. cleanups #158
Closed
Misc. cleanups #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the underlying issue that required a `skipLibCheck` in the first place.
Deploying topology with
|
| Latest commit: |
526ea9d
|
| Status: | ⚡️ Build in progress... |
jamesdabbs
commented
Jun 15, 2024
| @@ -17,7 +17,7 @@ jobs: | |||
|
|
|||
| # https://github.com/pnpm/action-setup | |||
| - name: Install pnpm | |||
| uses: pnpm/action-setup@v2 | |||
| uses: pnpm/action-setup@v4 | |||
There was a problem hiding this comment.
The previous action versions were deprecated and did not support new versions of node.
| @@ -30,6 +30,14 @@ | |||
| color: #fff; | |||
| } | |||
|
|
|||
| .example { | |||
There was a problem hiding this comment.
For a11y reasons, the examples should be clickable elements. This should preserve the previous styling.
defining it as a function means we can simplify the reactivity
|
Sim. this was merged in with #160 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleans up various deprecation and build warnings and does some minor cleanup and refactoring on touched files.
Testing Notes