Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue#155, using bit masking #157

Merged
merged 5 commits into from
Apr 7, 2020
Merged

Issue#155, using bit masking #157

merged 5 commits into from
Apr 7, 2020

Conversation

SamuelmsWong-zz
Copy link
Contributor

@SamuelmsWong-zz SamuelmsWong-zz commented Jan 18, 2020 •
edited
Loading

Builds off #156

@SamuelmsWong-zz
Copy link
Contributor Author

SamuelmsWong-zz commented Jan 18, 2020 •
edited
Loading

I don't quite remember why, but during the summer I remember discussing and concluding to use bit masking instead of bit fields.
However it was a while ago and as an afterthought to submitting this PR, I think it might be worth quickly deciding again which is better/easier.

@phillipstanleymarbell phillipstanleymarbell merged commit 587e3ad into master Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phillipstanleymarbell phillipstanleymarbell phillipstanleymarbell approved these changes

@btsouts btsouts Awaiting requested review from btsouts

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SamuelmsWong-zz @phillipstanleymarbell