Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MSVC compiler version detection #14810

Merged
merged 1 commit into from
Jul 5, 2024
Merged

Commits on Jul 4, 2024

  1. Update MSVC compiler version detection

    As of Visual Studio 2015, the major version of the compiler (`cl.exe`)
    is 19, and the minor version increases by steps of 10.  However, the
    latest Visual Studio 2022 release has the version `19.40`, so that
    Visual Studio version is not properly detected.  This is not a big deal
    regarding the reported compiler version (`php -v` etc.), but the
    filenames of the builds would no longer match the expectations (instead
    of `vs17` there is now `19.40.33811` or another build number).  This
    implies that the files would have to be renamed manually to be properly
    handled by windows.php.net (or that code would have to be adapted).
    
    Therefore we update the version detection to detect all versions < 1950
    as Visual Studio 2022, assuming that "For major releases, the minor
    version increases by 10."[1] still holds in the future.
    
    [1] <https://learn.microsoft.com/en-us/cpp/overview/compiler-versions?view=msvc-170#visual-studio-2017-and-later>
    cmb69 committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    78b10b5 View commit details
    Browse the repository at this point in the history