Update MSVC compiler version detection #14810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The failed |
nielsdos
approved these changes
Jul 4, 2024
|
That would be more a feature IMO as we don't officially support such builds for 8.3 and we no longer allow any features to stable version. So should be only for master. |
As of Visual Studio 2015, the major version of the compiler (`cl.exe`) is 19, and the minor version increases by steps of 10. However, the latest Visual Studio 2022 release has the version `19.40`, so that Visual Studio version is not properly detected. This is not a big deal regarding the reported compiler version (`php -v` etc.), but the filenames of the builds would no longer match the expectations (instead of `vs17` there is now `19.40.33811` or another build number). This implies that the files would have to be renamed manually to be properly handled by windows.php.net (or that code would have to be adapted). Therefore we update the version detection to detect all versions < 1950 as Visual Studio 2022, assuming that "For major releases, the minor version increases by 10."[1] still holds in the future. [1] <https://learn.microsoft.com/en-us/cpp/overview/compiler-versions?view=msvc-170#visual-studio-2017-and-later>
cmb69
requested review from
kocsismate,
dstogov,
iluuu1994,
arnaud-lb,
NattyNarwhal,
alexdowad,
bukka,
devnexen,
derickr,
adoy and
TimWolla
as code owners
|
Thanks @bukka. I've rebased onto master, which apparently triggered a code review request from a couple of people – sorry for that. |
|
Welcome back @cmb69 at pull requests 👍 and thanks for all your work on Windows builds. :D |
|
Welcome back @cmb69 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of Visual Studio 2015, the major version of the compiler (
cl.exe) is 19, and the minor version increases by steps of 10. However, the latest Visual Studio 2022 release has the version19.40, so that Visual Studio version is not properly detected. This is not a big deal regarding the reported compiler version (php -vetc.), but the filenames of the builds would no longer match the expectations (instead ofvs17there is now19.40.33811or another build number). This implies that the files would have to be renamed manually to be properly handled by windows.php.net (or that code would have to be adapted).Therefore we update the version detection to detect all versions < 1950 as Visual Studio 2022, assuming that "For major releases, the minor version increases by 10."[1] still holds in the future.
[1] https://learn.microsoft.com/en-us/cpp/overview/compiler-versions?view=msvc-170#visual-studio-2017-and-later
Note that I have targeted
PHP-8.3since there may be custom builds which use Visual Studio 2022, so they get a "proper" compiler detection, although that might break some build scripts. Thus, it might be best to only apply this patch tomaster, because in my opinion PHP 8.4 should be built with Visual Studio 2022, although Visual Studio 2019 still has extended support until 2029-04-10.