Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove no use out_dir #735

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

linshokaku
Copy link
Member

@linshokaku linshokaku commented Jul 31, 2023

Remove the out_dir argument of Writer.__call__ since it does not affect the behavior of the program.

cf.

@emcastillo
Copy link
Contributor

emcastillo commented Aug 1, 2023

Discussed offline:

1- This PR is non-compat as some users may directly call writer.save in Extensions or related code
2- In order to avoid disruption there are some alternatives

  • Keep the original interface but add a deprecation warning
  • Make the out_dir parameter optional (None) and use it to override the Writer.out_dir attribute when needed
  • Check the writer's design and think on a large scope if things like out_dir makes sense and how can it affect user codes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants