Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use argument out_dir not self.out_dir #812

Closed
wants to merge 1 commit into from

Conversation

nzw0301
Copy link

@nzw0301 nzw0301 commented Mar 21, 2024

I'm not sure this is intended, but the currently we cannot specify out_dir from the argument because self.out_dir is always used.

@linshokaku
Copy link
Member

We have considered revisions in #735, however, either of the following is required:

  • A change in the behavior that is non-obvious to users
  • Breaking backwards compatibility
    • We believe there may be implications for users who utilize subclasses inheriting the Writer class.

Therefore, while the implementation can lead to misunderstandings, we concluded that it does not amount to a critical issue.

@nzw0301 nzw0301 closed this Aug 5, 2024
@kmaehashi kmaehashi added this to the Closed PRs milestone Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants