fix: solve the app install callback url #461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Walkthrough此 PR 修复了安装应用后页面无法正常渲染的问题。主要通过更新回调 URL 的格式和确保某些 ID 字段被正确转换为字符串来实现。 Changes
|
![petercat-assistant[bot]](https://avatars.githubusercontent.com/in/875736?s=60&v=4){kind=small}
| robot_id="", | ||
| created_at=int(time.time()), | ||
| ) | ||
| repository_config_dao.create(repository_config) | ||
|
|
||
| return RedirectResponse( | ||
| url=f"{WEB_URL}/github/installed/{message}", status_code=302 | ||
| url=f"{WEB_URL}/github/installed?message={message}", status_code=302 |
There was a problem hiding this comment.
The change from url=f"{WEB_URL}/github/installed/{message}" to url=f"{WEB_URL}/github/installed?message={message}" fixes the issue with the callback URL not being correctly formatted, which could have led to rendering issues after app installation.
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
xingwanying
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
修复安装 app 后页面无法正常渲染的bug