Skip to content

Commit

Permalink
fix: solve the app install callback url (#461)
Browse files Browse the repository at this point in the history
* fix(install): stringify ownerid

* fix(install): stringify install repo id

* fix(install): fix install app callback url

* refactor(app_install): update error message
  • Loading branch information
ch-liuzhide authored Nov 12, 2024
1 parent 6e3c732 commit 562c258
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions server/github_app/router.py
Original file line number Diff line number Diff line change
Expand Up @@ -85,12 +85,12 @@ def github_app_callback(code: str, installation_id: str, setup_action: str):
repository_config_dao.create(repository_config)

return RedirectResponse(
url=f"{WEB_URL}/github/installed/{message}", status_code=302
url=f"{WEB_URL}/github/installed?message={message}", status_code=302
)
# ignore others setup_action,such as deleted our app
return {
"success": False,
"message": f"Invalid setup_action value {setup_action}",
"message": f"Invalid setup_action value {setup_action},please delete the app first then re-install the app.",
}


Expand Down

0 comments on commit 562c258

Please sign in to comment.