Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PG-592 Treat queries with different parent queries as separate entries #403

Merged
merged 9 commits into from
Aug 6, 2024

Commits on Jun 29, 2023

  1. PG-592: Treat queries with different parent queries as separate entries

    1. Previously pg_stat_monitor had a `topquery` and `topqueryid` field, but it was only a sample:
    it showed one of the top queries executing the specific query.
    
    With this change, the same entry executed by two different functions will result in two entries in the statistics table.
    
    2. This also fixes a bug where the content of these field disappeared for every second query executed:
    previously the update function changed topqueryid to `0` if it was non zero, and changed it to the proper id when it was 0.
    This resulted in an alternating behavior, where for every second executed query the top query disappeared.
    
    After these changes, the top query is always shown.
    
    3. The previous implementation also leaked dsa memory used to store the parent queries. This is now also fixed.
    dutow committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    981f707 View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2023

  1. PG-502: Fixing review comments

    * dsa_free changed to assert as it can never happen
    * restructured the ifs to be cleaner
      Note: kept the two-level ifs, as that makes more sense with the assert
      Note: didn't convert nested_level checks to macro, as it is used differently at different parts of the code
    dutow committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    8caa3ea View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2023

  1. PG-502: Fixing review comments

    dutow committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    3c8549e View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2024

  1. Configuration menu
    Copy the full SHA
    6fdb761 View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2024

  1. Configuration menu
    Copy the full SHA
    6217019 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    381137b View commit details
    Browse the repository at this point in the history
  3. Remove redundant line

    artemgavrilov committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    ada6352 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2024

  1. Configuration menu
    Copy the full SHA
    605a808 View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2024

  1. Configuration menu
    Copy the full SHA
    bf208ea View commit details
    Browse the repository at this point in the history