-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PG-592 Treat queries with different parent queries as separate entries #403
Conversation
1. Previously pg_stat_monitor had a `topquery` and `topqueryid` field, but it was only a sample: it showed one of the top queries executing the specific query. With this change, the same entry executed by two different functions will result in two entries in the statistics table. 2. This also fixes a bug where the content of these field disappeared for every second query executed: previously the update function changed topqueryid to `0` if it was non zero, and changed it to the proper id when it was 0. This resulted in an alternating behavior, where for every second executed query the top query disappeared. After these changes, the top query is always shown. 3. The previous implementation also leaked dsa memory used to store the parent queries. This is now also fixed.
* dsa_free changed to assert as it can never happen * restructured the ifs to be cleaner Note: kept the two-level ifs, as that makes more sense with the assert Note: didn't convert nested_level checks to macro, as it is used differently at different parts of the code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #403 +/- ##
==========================================
- Coverage 84.99% 84.87% -0.12%
==========================================
Files 3 3
Lines 1293 1296 +3
Branches 197 198 +1
==========================================
+ Hits 1099 1100 +1
Misses 98 98
- Partials 96 98 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
PG-592
topquery
andtopqueryid
field, but it was only a sample: it showed one of the top queries executing the specific query.With this change, the same entry executed by two different functions will result in two entries in the statistics table.
0
if it was non zero, and changed it to the proper id when it was 0. This resulted in an alternating behavior, where for every second executed query the top query disappeared.After these changes, the top query is always shown.