This repository has been archived by the owner on Apr 17, 2018. It is now read-only.
Adding address unit attribute to parsed properties #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
dianashk
requested review from
orangejulius,
trescube,
missinglink and
dianashk
sweco-semhul
changed the title
dianashk
approved these changes
Nov 10, 2017
|
@trescube , how hard will it be to update pelias/api#1060 for these changes? |
|
This looks great. Lets hold off on merging for now as we need to figure out how to deploy this for Mapzen Search. But we want it, and soon :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To resolve pelias/pelias#618 more details found in comments to that issue