Adding address unit attribute to api output and queries #1052
Conversation
ghost
added
the
middleware/localNamingConventions.js
Outdated
| if(place.address_parts.hasOwnProperty('unit')) { | ||
| unit = ' ' + place.address_parts.unit; | ||
| } | ||
| var standard = ( place.address_parts.number + unit + ' ' + place.address_parts.street ), |
There was a problem hiding this comment.
This line should be changed so that the unit is last. Also, the string concatenation approach is getting a bit messy here. It would be great if you updated the code to use Array.join. It can handle putting in appropriate whitespace pretty nicely
There was a problem hiding this comment.
Thanks for the clarification!
Yeah I agree on that. Will change the order and get it a bit less messy 😃
…ged concatination to be a bit cleaner using array.join
|
@orangejulius changes should be there now |
|
The pelias-text-analyzer has been deprecated and its code moved into the API. Please rebase this branch off of master. This should affect your code only slightly, so please move the text-analyzer changes to controller/libpostal.js. |
|
@trescube realised that I missed your request for changes. Moved it from text-analyzer to controller/libpostal.js |
To resolve pelias/pelias#618 more details found in comments to that issue