Skip to content
This repository has been archived by the owner on Jun 2, 2023. It is now read-only.

Separate hoverStart and hoverEnd from show/hide element #411

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Separate hoverStart and hoverEnd from show/hide element #411

wants to merge 4 commits into from

Commits on Oct 28, 2022

  1. Separate hoverStart and hoverEnd from show/hide element 

    I think it is a good functionality to separate the onHoverStart and onHoverEnd from the hover element, because it was called from the onClick and onDismiss respectively.
for this feature I have created:
 · `showElement`: the name says it all
 · `hideElement`: the name says it all

On the other hand, I have also added a feature, which has been requested by several people, which is to separate the hoverElement from the hover and show it only when onClick. 
For this feature I have created:
 · `addClickElement`: Same as `addElement`. But it automatically configures only the clickable element
 · `addElement`: Refactoring of the old addHoverElement method
 · `removeElement`: Refactoring of the old removeHoverElement method
 · `addClickText`: Same as `addTextElement`. But it automatically configures only the clickable element
 · `addTextElement`: Refactoring of the old `addHoverText` method

And I have added deprecated for:
 · `addRemoveElement`: Same as `removeElement`
 · `addHoverElement`: Same as `removeElement`
 · `addHoverText`: Same as `addTextElement`
    @JoseManuelFV
    JoseManuelFV authored Oct 28, 2022
    Configuration menu
    Copy the full SHA
    913b423 View commit details
    Browse the repository at this point in the history

  2. Condition showHoverElement in hover events

    @JoseManuelFV
    JoseManuelFV authored Oct 28, 2022
    Configuration menu
    Copy the full SHA
    295ef60 View commit details
    Browse the repository at this point in the history

  3. Condition showHoverElement in hover events

    @JoseManuelFV
    JoseManuelFV authored Oct 28, 2022
    Configuration menu
    Copy the full SHA
    1fbe8da View commit details
    Browse the repository at this point in the history

  4. Remove unused element variable

    @JoseManuelFV
    JoseManuelFV authored Oct 28, 2022
    Configuration menu
    Copy the full SHA
    af04676 View commit details
    Browse the repository at this point in the history