This repository has been archived by the owner on Jun 2, 2023. It is now read-only.
Separate hoverStart and hoverEnd from show/hide element #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think it is a good functionality to separate the onHoverStart and onHoverEnd from the hover element, because it was called from the onClick and onDismiss respectively. for this feature I have created: · `showElement`: the name says it all · `hideElement`: the name says it all On the other hand, I have also added a feature, which has been requested by several people, which is to separate the hoverElement from the hover and show it only when onClick. For this feature I have created: · `addClickElement`: Same as `addElement`. But it automatically configures only the clickable element · `addElement`: Refactoring of the old addHoverElement method · `removeElement`: Refactoring of the old removeHoverElement method · `addClickText`: Same as `addTextElement`. But it automatically configures only the clickable element · `addTextElement`: Refactoring of the old `addHoverText` method And I have added deprecated for: · `addRemoveElement`: Same as `removeElement` · `addHoverElement`: Same as `removeElement` · `addHoverText`: Same as `addTextElement`
|
This pull request introduces 1 alert when merging 913b423 into 562ff9d - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging 295ef60 into 562ff9d - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging 1fbe8da into 562ff9d - view on LGTM.com new alerts:
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added 3 feactures:
Separate the onHoverStart and onHoverEnd from the hover element, because it was called from the onClick and onDismiss respectively, and I believe that the events should be worked separately, not that one should call the other one.
For this feature I have created:
·
showElement: the name says it all·
hideElement: the name says it allOn the other hand, I have also added a feature, which has been requested by several people, which is to separate the hoverElement from the hover and show it only when onClick.
For this feature I have created:
·
addClickElement: Same asaddElement. But it automatically configures only the clickable element·
addElement: Refactoring of the old addHoverElement method·
removeElement: Refactoring of the old removeHoverElement method·
addClickText: Same asaddTextElement. But it automatically configures only the clickable element·
addTextElement: Refactoring of the oldaddHoverTextmethod·
showHoverElement: Configuration for only clicable elementI have added deprecated for:
·
removeHoverElement: Same asremoveElement·
addHoverElement: Same asremoveElement·
addHoverText: Same asaddTextElementThe posts that mention/ask for this feature:
Feacture 1: #333 #268
Feacture 2: #394 #272