Skip to content
This repository has been archived by the owner on Jun 2, 2023. It is now read-only.

Fix multiple CubePanorama, same opacity issue #341

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Commits on Jun 28, 2021

  1. Fix multiple CubePanorama, same opacity issue

    When the `uniform` object isn't deep cloned, multiple `CubePanorama` objects have the same `material.uniforms.opacity` object. This causes an issue if they're linked. After the transition is complete, the first cube's `opacity` turns `false` and since they're identical, the new one's also do. So the user ends up with a black screen. The `THREE.ShaderLib[ 'cube' ]` probably needs to be deep cloned but I wanted to make the minimum amount of changes to fix the issue.
    toramanlis authored Jun 28, 2021
    Configuration menu
    Copy the full SHA
    370b361 View commit details
    Browse the repository at this point in the history