This repository has been archived by the owner on Jun 2, 2023. It is now read-only.
Fix multiple CubePanorama, same opacity issue #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the `uniform` object isn't deep cloned, multiple `CubePanorama` objects have the same `material.uniforms.opacity` object. This causes an issue if they're linked. After the transition is complete, the first cube's `opacity` turns `false` and since they're identical, the new one's also do. So the user ends up with a black screen. The `THREE.ShaderLib[ 'cube' ]` probably needs to be deep cloned but I wanted to make the minimum amount of changes to fix the issue.
|
I have the same problem when linking multiple CubePanorama objects. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
uniformobject isn't deep cloned, multipleCubePanoramaobjects have the samematerial.uniforms.opacityobject. This causes an issue if they're linked. After the transition is complete, the first cube'sopacityturnsfalseand since they're identical, the new one's also do. So the user ends up with a black screen. TheTHREE.ShaderLib[ 'cube' ]probably needs to be deep cloned but I wanted to make the minimum amount of changes to fix the issue.