Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grep_more_ioc fix pandas silent downcasting spam #225

Merged
merged 2 commits into from
Nov 21, 2024
Merged

grep_more_ioc fix pandas silent downcasting spam #225

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6c066d0
MNT: Fix pandas 3.0 future warnings about silent downcasting
aberges-SLAC Nov 20, 2024
2005ed1
Merge branch 'grep_more_ioc' of github.com:aberges-SLAC/engineering_t…
aberges-SLAC Nov 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions scripts/grep_more_ioc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -492,15 +492,19 @@ def main():
# pad the disable column based on the grep_ioc output
if 'disable' not in df.columns:
df['disable'] = df.index.size*[False]
if 'disable' in df.columns:
df['disable'] = df['disable'].fillna(False).astype(bool)
# handle stupid pandas 3.0 future warnings early
with pd.option_context('future.no_silent_downcasting', True):
if 'disable' in df.columns:
df['disable'] = (df['disable'].infer_objects().fillna(False))

# Fill the NaN with empty strings for rarely used keys
for _col in df.columns:
if _col not in ['delay']:
df[_col] = df[_col].fillna('')
else:
df[_col] = df[_col].fillna(0)
# handle stupid pandas 3.0 future warnings early
with pd.option_context('future.no_silent_downcasting', True):
for _col in df.columns:
if _col not in ['delay']:
df[_col] = df[_col].infer_objects().fillna('')
else:
df[_col] = df[_col].infer_objects().fillna(0)

# check for the ignore_disabled flag
if args.ignore_disabled is True:
Expand Down