grep_more_ioc fix pandas silent downcasting spam #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tangkong
approved these changes
Nov 20, 2024
Yeah it's extremely annoying that the only way to make it go away is to opt into the future behavior, even if you avoided down casting in the first place. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Small fix to close #224 spamming terminal with the future warnings. Kind of a weird problem for these calls in pandas, take a look at pandas-dev/pandas#57734 if you're interested.
Motivation and Context
Wanted to fix the warning spam and stay ahead of changes
How Has This Been Tested?
Have ran
grep_more_ioclocally on my branch and confirmed the spam goes away and the script works as intended:Where Has This Been Documented?
This PR