-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add dev container configuration #112
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting. I have never used this but see the value in it.
Would you mind adding a minimal "usage" guide to docs/development.md
(and a Changelog entry)?
@pgrete What is the username you use in the CI container? I tried
|
Yes, I should probably update those at some point. |
@pgrete I can't build in the CI container, because it can't find HDF5. Since the CI works, it has to be there, right? Could you try opening the container and see if you can build?
|
Ah, I see why it can't find it. Would it make sense to use a newer container image, and install openmpi and hdf5 via the package manager instead? |
If you find out a way install the serial and parallel version of hdf5 at the same time from the package manager, then yes. It's the only reason I do the manual install. |
Why is it necessary to install both? |
Because we also test the serial/non-MPI version of Parthenon (and that requires the non-mpi HDf5 version). |
When I try to run in the container, I get:
Is this expected? |
Ok, I've tested it on Codespaces. Let me know if everything works for you. Otherwise, it should be ready to go. |
Are you running in a "cuda-aware" docker container? Might be looking for the forwarded cuda libs from the host. |
No, I'm running on GitHub codespaces, which does not have GPUs. This suppresses the warning: https://github.com/parthenon-hpc-lab/athenapk/pull/112/files#diff-24ad71c8613ddcf6fd23818cb3bb477a1fb6d83af4550b0bad43099813088686R32 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fixes. I just confirmed that this works on my end as expected.
I've added a
.devcontainer
subdirectory in the repo that enables GitHub Codespaces and VSCode Dev Containers. It will use the CUDA CI container image and re-open the repository in that container.This should make reproducibility easy, plus make it easier to new contributors to get started. New dependences, e.g., for openPMD, can also be added.