Skip to content

Commit

Permalink
Merge pull request #112 from parthenon-hpc-lab/BenWibking/add-devcont…
Browse files Browse the repository at this point in the history
…ainer

add dev container configuration
  • Loading branch information
BenWibking authored Aug 26, 2024
2 parents 3daf5c9 + 76d9e95 commit 87429d2
Show file tree
Hide file tree
Showing 3 changed files with 47 additions and 0 deletions.
40 changes: 40 additions & 0 deletions .devcontainer/devcontainer.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
// devcontainer.json
{
"name": "athenapk-dev",
"image": "ghcr.io/parthenon-hpc-lab/cuda11.6-mpi-hdf5-ascent",
// disable Dockerfile for now
//"build": {
// // Path is relative to the devcontainer.json file.
// "dockerfile": "Dockerfile"
//},
"hostRequirements": {
"cpus": 4
},
"customizations": {
"vscode": {
"settings": {},
"extensions": [
"-ms-vscode.cpptools",
"llvm-vs-code-extensions.vscode-clangd",
"github.vscode-pull-request-github",
"ms-python.python",
"ms-toolsai.jupyter",
"ms-vscode.live-server",
"ms-azuretools.vscode-docker",
"swyddfa.esbonio",
"tomoki1207.pdf",
"ms-vscode.cmake-tools",
"ms-vsliveshare.vsliveshare"
]
}
},
"remoteEnv": {
"PATH": "${containerEnv:PATH}:/usr/local/hdf5/parallel/bin",
"OMPI_MCA_opal_warn_on_missing_libcuda": "0"
},
//"remoteUser": "ubuntu",
// we need to manually checkout the submodules,
// but VSCode may try to configure CMake before they are fully checked-out.
// workaround TBD
"postCreateCommand": "git submodule update --init"
}
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
### Fixed (not changing behavior/API/variables/...)

### Infrastructure
- [[PR 112]](https://github.com/parthenon-hpc-lab/athenapk/pull/112) Add dev container configuration
- [[PR 105]](https://github.com/parthenon-hpc-lab/athenapk/pull/105) Bump Parthenon to latest develop (2024-03-13)
- [[PR 84]](https://github.com/parthenon-hpc-lab/athenapk/pull/84) Added `CHANGELOG.md`

Expand Down
6 changes: 6 additions & 0 deletions docs/development.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,9 @@ All pull requests are checked automatically if the code is properly formatted.

The build target `format-athenapk` calls both formatters and automatically format all changes, i.e., before committing changes simply call `make format-athenapk` (or similar).
Alternatively, leave a comment with `@par-hermes format` in the open pull request to format the code directly on GitHub.

## Dev container

You can open a [GitHub Codespace](https://docs.github.com/en/codespaces) or use VSCode to automatically open local Docker container using the CUDA CI container image.

If you have the [VSCode Dev Container extension](https://marketplace.visualstudio.com/items?itemName=ms-vscode-remote.remote-containers) installed, on opening this repository in VSCode, it will automatically prompt to ask if you want to re-open this repository in a container.

0 comments on commit 87429d2

Please sign in to comment.