Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add clippy and fmt #5

Merged
merged 3 commits into from
Mar 5, 2024
Merged

Add clippy and fmt #5

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e5590d0
ci: Add cargo fmt
gowthamsk-arm Feb 22, 2024
90b8b3d
ci: Add cargo clippy to CI
gowthamsk-arm Feb 22, 2024
1a24cad
CI: Split jobs
gowthamsk-arm Feb 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ci.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,3 +32,7 @@ echo "Parsec OpenSSL Provider loaded successfully!!!!"
if cargo fmt --version; then
cargo fmt --all -- --check
fi

if cargo clippy --version; then
cargo clippy --all-targets -- -D clippy::all -D clippy::cargo
fi
1 change: 1 addition & 0 deletions parsec-openssl-provider-shared/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ readme = "README.md"
keywords = ["security", "service"]
categories = ["cryptography", "hardware-support"]
edition = "2021"
repository = "https://github.com/parallaxsecond/parsec-openssl-provider"

[lib]
crate-type = ["cdylib"]
Expand Down
1 change: 1 addition & 0 deletions parsec-openssl-provider/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ readme = "README.md"
keywords = ["security", "service"]
categories = ["cryptography", "hardware-support"]
edition = "2021"
repository = "https://github.com/parallaxsecond/parsec-openssl-provider"

[dependencies]
parsec-openssl2 = { path = "../parsec-openssl2" }
Expand Down
2 changes: 2 additions & 0 deletions parsec-openssl-provider/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
// Copyright 2023 Contributors to the Parsec project.
// SPDX-License-Identifier: Apache-2.0
#![allow(clippy::missing_safety_doc)]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is clippy using publicly visible unsafe functions ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes the parsec_provider_provider_init here is dealing with C pointers as it will be at the FFI boundary.


use std::mem;

pub use openssl_errors;
Expand Down
5 changes: 5 additions & 0 deletions parsec-openssl-sys2/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,13 @@
name = "parsec-openssl-sys2"
version = "0.1.0"
license = "Apache-2.0"
description = "FFI wrapper around the OpenSSL API"
authors = ["Parsec Project Contributors"]
edition = "2021"
repository = "https://github.com/parallaxsecond/parsec-openssl-provider"
categories = ["api-bindings", "external-ffi-bindings", "cryptography", "hardware-support"]
readme = "README.md"
keywords = ["security", "openssl"]

[build-dependencies]
bindgen = { version = "0.66.1" }
5 changes: 5 additions & 0 deletions parsec-openssl2/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,12 @@ name = "parsec-openssl2"
version = "0.1.0"
license = "Apache-2.0"
authors = ["Parsec Project Contributors"]
description = "Rust-native wrapper around the OpenSSL API"
edition = "2021"
repository = "https://github.com/parallaxsecond/parsec-openssl-provider"
categories = ["api-bindings", "external-ffi-bindings", "cryptography", "hardware-support"]
readme = "README.md"
keywords = ["security", "openssl"]

[dependencies]
parsec-openssl-sys2 = { path = "../parsec-openssl-sys2" }
Expand Down
1 change: 1 addition & 0 deletions parsec-openssl2/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
// Copyright 2023 Contributors to the Parsec project.
// SPDX-License-Identifier: Apache-2.0
#![allow(clippy::missing_safety_doc)]

pub use openssl_sys::OSSL_PROVIDER;
pub use parsec_openssl_sys2::openssl_binding;
Expand Down
Loading