Add clippy and fmt #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gowtham Suresh Kumar <[email protected]>
Signed-off-by: Gowtham Suresh Kumar <[email protected]>
gowthamsk-arm
force-pushed
the
ci_test
branch
2 times, most recently
from
c5d7950
to
d339be8
Compare
| @@ -1,5 +1,7 @@ | |||
| // Copyright 2023 Contributors to the Parsec project. | |||
| // SPDX-License-Identifier: Apache-2.0 | |||
| #![allow(clippy::missing_safety_doc)] | |||
There was a problem hiding this comment.
Is clippy using publicly visible unsafe functions ?
There was a problem hiding this comment.
Yes the parsec_provider_provider_init here is dealing with C pointers as it will be at the FFI boundary.
ci.sh
Outdated
| shift | ||
| done | ||
|
|
||
| if [ "$BUILD_AND_TEST" ]; then |
There was a problem hiding this comment.
This is tricky. It will work as is, but it can be prone to bugs.
We should either check that the variable is non zero len [[ -n $var ]] or perform a string comparison.
Or we can use boolean variables using BUILD_AND_TEST=false at line 32 and BUILD_AND_TEST=true
There was a problem hiding this comment.
Sorry for the delay. Yes, I will update it with a boolean.
This patch adds a ci_script GitHub action and splits the jobs to run specific tests. Signed-off-by: Gowtham Suresh Kumar <[email protected]>
tgonzalezorlandoarm
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds clippy and fmt to the CI along with changes needed to pass.
Signed-off-by: Gowtham Suresh Kumar [email protected]