Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make RPC cache generic over primitives #13146

Merged
merged 3 commits into from
Dec 5, 2024
Merged

feat: make RPC cache generic over primitives #13146

merged 3 commits into from
Dec 5, 2024

Conversation

klkvr
Copy link
Collaborator

@klkvr klkvr commented Dec 5, 2024

Closes #13047

Changes EthStateCache to operate on block and receipt generics instead of concrete types.

This is done by enforcing Provider: BlockReader bound on struct definitions and using Provider::Block and Provider::Receipt ATs.

This required adding some redundant bounds to all impls of EthApi and OpEthApi.

@github-actions github-actions bot added the C-enhancement New feature or request label Dec 5, 2024
@klkvr klkvr added the A-rpc Related to the RPC implementation label Dec 5, 2024
@klkvr klkvr mentioned this pull request Dec 5, 2024
Closed
mattsse
mattsse approved these changes Dec 5, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty,

cc @lean-apple could be relevant for #13069

@mattsse mattsse added this pull request to the merge queue Dec 5, 2024
Merged via the queue into main with commit b4124dd Dec 5, 2024
42 checks passed
@mattsse mattsse deleted the klkvr/rpc-cache-prims branch December 5, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@joshieDo joshieDo Awaiting requested review from joshieDo joshieDo is a code owner

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@emhane emhane Awaiting requested review from emhane

@fgimenez fgimenez Awaiting requested review from fgimenez fgimenez is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
A-rpc Related to the RPC implementation C-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Make EthStateCache generic over primitives
2 participants
@klkvr @mattsse