-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Make CacheAction
generic over NodePrimitives
#13048
Labels
C-enhancement
New feature or request
D-good-first-issue
Nice and easy! A great choice to get started
S-needs-triage
This issue needs to be labelled
Comments
klkvr
added
C-enhancement
New feature or request
S-needs-triage
This issue needs to be labelled
labels
Dec 1, 2024
Hi @klkvr, can i take this issue? Thanks |
@htiennv sure! assigned |
Thanks @klkvr |
I'd love to work on this! |
hey @htiennv do you need any help here? |
Hi @klkvr, I have some things to do so I haven't been online often in the past few days. Sorry for the delay |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
C-enhancement
New feature or request
D-good-first-issue
Nice and easy! A great choice to get started
S-needs-triage
This issue needs to be labelled
Describe the feature
We need to add
NodePrimitives
generic toreth/crates/rpc/rpc-eth-types/src/cache/mod.rs
Lines 498 to 529 in 890f082
It needs to be added to the struct impl and passed to all variants fields. This will require making some other types generic over Block/NodePrimitives (e.g.
ChainChange
would need entire NodePrimitives andBlockWithSendersResponseSender
justBlock
)Additional context
No response
The text was updated successfully, but these errors were encountered: