add more module mappings for popular packages #20551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
purajit
changed the title
huonw
added a commit
that referenced
this pull request
Apr 4, 2024
Several of mappings for opentelemetry packages were added/adjusted in #20551 and then adjusted more in #20705, but the second adjustment was based on the default fallback mapping replacing `-` with `.`, but it actually replaces them with `_`. This restores explicit mappings for the following (where I've downloaded the wheels and verified their contents): - `opentelemetry-exporter-otlp` - `opentelemetry-exporter-otlp-proto-grpc` - `opentelemetry-exporter-otlp-proto-http` - `opentelemetry-sdk` These were originally added in #16337, released in 2.14.0, so this would be a notable regression if we released 2.20.0 without them. Noticed in #20705 (comment)
WorkerPants
pushed a commit
that referenced
this pull request
Apr 4, 2024
Several of mappings for opentelemetry packages were added/adjusted in #20551 and then adjusted more in #20705, but the second adjustment was based on the default fallback mapping replacing `-` with `.`, but it actually replaces them with `_`. This restores explicit mappings for the following (where I've downloaded the wheels and verified their contents): - `opentelemetry-exporter-otlp` - `opentelemetry-exporter-otlp-proto-grpc` - `opentelemetry-exporter-otlp-proto-http` - `opentelemetry-sdk` These were originally added in #16337, released in 2.14.0, so this would be a notable regression if we released 2.20.0 without them. Noticed in #20705 (comment)
huonw
added a commit
that referenced
this pull request
Apr 4, 2024
…20753) Several of mappings for opentelemetry packages were added/adjusted in #20551 and then adjusted more in #20705, but the second adjustment was based on the default fallback mapping replacing `-` with `.`, but it actually replaces them with `_`. This restores explicit mappings for the following (where I've downloaded the wheels and verified their contents): - `opentelemetry-exporter-otlp` - `opentelemetry-exporter-otlp-proto-grpc` - `opentelemetry-exporter-otlp-proto-http` - `opentelemetry-sdk` These were originally added in #16337, released in 2.14.0, so this would be a notable regression if we released 2.20.0 without them. Noticed in #20705 (comment) Co-authored-by: Huon Wilson <[email protected]>
cburroughs
added a commit
to cburroughs/pants
that referenced
this pull request
Apr 17, 2024
In pantsbuild#20551 the opentelemetry module mappings were expanded -- yeah! -- but in the transition of `opentelemetry-api` from a wildcard to explicit list, this sub-module was missed. See https://github.com/open-telemetry/opentelemetry-python/tree/v1.24.0/opentelemetry-api/src/opentelemetry
kaos
pushed a commit
that referenced
this pull request
Apr 18, 2024
In #20551 the opentelemetry module mappings were expanded -- yeah! -- but in the transition of `opentelemetry-api` from a wildcard to explicit list, this sub-module was missed. See https://github.com/open-telemetry/opentelemetry-python/tree/v1.24.0/opentelemetry-api/src/opentelemetry
WorkerPants
pushed a commit
that referenced
this pull request
Apr 18, 2024
In #20551 the opentelemetry module mappings were expanded -- yeah! -- but in the transition of `opentelemetry-api` from a wildcard to explicit list, this sub-module was missed. See https://github.com/open-telemetry/opentelemetry-python/tree/v1.24.0/opentelemetry-api/src/opentelemetry
kaos
pushed a commit
that referenced
this pull request
Apr 18, 2024
…) (#20810) In #20551 the opentelemetry module mappings were expanded -- yeah! -- but in the transition of `opentelemetry-api` from a wildcard to explicit list, this sub-module was missed. See https://github.com/open-telemetry/opentelemetry-python/tree/v1.24.0/opentelemetry-api/src/opentelemetry Co-authored-by: cburroughs <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added more default module mappings of popular packages