Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce source distribution size #338

Merged
merged 6 commits into from
Dec 10, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .gitattributes
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
# Added by versioneer
euphonic/_version.py export-subst
.github/** export-ignore
tests_and_analysis/** export-ignore
tox.ini export-ignore
64 changes: 23 additions & 41 deletions .github/workflows/build_upload_pypi_wheels.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,29 +6,7 @@ on:
workflow_dispatch:

jobs:
build-sdist:
name: Build sdist
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v4
with:
fetch-depth: 0 # Ensure tags are fetched for versioning

- name: Create source distribution
shell: bash -l {0}
run: |
pipx run build --sdist .

- name: Upload source dist as build artifact
uses: actions/upload-artifact@v4
with:
name: python-source-distribution
path: dist/
if-no-files-found: error

build-wheels:
needs: build-sdist
strategy:
matrix:
os: [windows-latest, macos-13, macos-latest, ubuntu-latest]
Expand Down Expand Up @@ -58,21 +36,6 @@ jobs:
- name: Checkout project (for test files)
uses: actions/checkout@v4

- name: Delete source (to ensure we are using sdist only)
shell: bash -l {0}
run: rm -rf euphonic

- name: Download sdist
uses: actions/download-artifact@v4
with:
name: python-source-distribution
path: dist/

- name: Get sdist filename
shell: bash -l {0}
run: |
echo EUPHONIC_SDIST="$(find dist/ -name 'euphonic*.tar.gz')" >> $GITHUB_ENV

- name: Setup Python ${{ matrix.python-version }}
uses: actions/setup-python@v5
with:
Expand Down Expand Up @@ -113,7 +76,7 @@ jobs:
run: |
python -m pip install --upgrade pip build wheel twine

- name: Build wheels from sdist
- name: Build wheels from git checkout
uses: pypa/[email protected]
env:
CIBW_BUILD_FRONTEND: build
Expand All @@ -124,11 +87,10 @@ jobs:
CIBW_REPAIR_WHEEL_COMMAND_MACOS: ""

CIBW_TEST_EXTRAS: "test,brille,phonopy_reader,matplotlib"
CIBW_TEST_COMMAND: python {package}/tests_and_analysis/test/run_tests.py
CIBW_TEST_COMMAND: "python {package}/tests_and_analysis/test/run_tests.py"

with:
output-dir: wheelhouse
package-dir: ${{ env.EUPHONIC_SDIST }}

- name: Upload wheels as build artifacts
uses: actions/upload-artifact@v4
Expand All @@ -137,6 +99,27 @@ jobs:
path: wheelhouse/*-${{ matrix.wheelname }}*_${{ matrix.cibw_archs }}.whl
if-no-files-found: error

build-sdist:
name: Build sdist
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v4
with:
fetch-depth: 0 # Ensure tags are fetched for versioning

- name: Create source distribution
shell: bash -l {0}
run: |
pipx run build --sdist .

- name: Upload source dist as build artifact
uses: actions/upload-artifact@v4
with:
name: python-source-distribution
path: dist/
if-no-files-found: error

test-sdist:
needs: build-sdist
name: Test build from sdist on Windows
Expand Down Expand Up @@ -194,7 +177,6 @@ jobs:
shell: bash -l {0}
run: python tests_and_analysis/test/run_tests.py --report


publish:
if: github.event_name == 'release'
needs: [build-wheels,test-sdist]
Expand Down
Loading