Reduce source distribution size #338
Conversation
meson-python uses git-archive to create the sdist. Some of euphonic's test files are on the large side and we don't need to include them with every copy of the source. This does have the downside that git-archive can no longer be used to produce a copy of the source with tests, but we weren't using that anyway.
|
Interesting, the tests were running from the sdist! Looks like there is more work to do on the wheel-build action, then |
ajjackson
force-pushed
the
package-size
branch
from
c986349 to
a73cd7c
Compare
ajjackson
force-pushed
the
package-size
branch
from
a73cd7c to
feab9e3
Compare
ajjackson
force-pushed
the
package-size
branch
from
92d7af6 to
d5b78e3
Compare
|
Some very puzzling stuff going on here: the wheel tests are failing only on Linux, where it claims to be unable to find the run_tests.py. The file is clearly visible from
|
Maybe abs paths don't work well here for some reason?
|
Ahhh... I see the problem. The linux builds are running in a (manylinux) container, so they don't have access to the filesystem. In that case, I think the options are a) build Linux (and other platforms?) from the git checkout and not the sdist; or b) offers a tiny bit more purity for a lot of extra work. Let's do a) |
While the purity of building from sdist was appealing, it is difficult for cibuildwheel to cleanly run an external test suite as it containerizes the Linux build (to deal with ManyLinux requirements). We are still testing the sdist (on Windows) so just have to trust in cibuildwheel's own efforts to separate the testing and source from the installation. (Which it does seem to work quite hard at.)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## test_windows_sdist #338 +/- ##
=====================================================
Coverage ? 95.43%
=====================================================
Files ? 29
Lines ? 4209
Branches ? 641
=====================================================
Hits ? 4017
Misses ? 114
Partials ? 78 ☔ View full report in Codecov by Sentry. |
|
All green, finally 😮💨 https://github.com/pace-neutrons/Euphonic/actions/runs/12261330267 The sdist is still almost 10x the wheel size at 1MB. Probably due to docs/images; may as well strip those out as well? |
Depends on #337
meson-python uses git-archive to create the sdist. Some of euphonic's test files are on the large side and we don't need to include them with every copy of the source.
This does have the downside that git-archive can no longer be used to produce a copy of the source with tests, but we weren't using that anyway.