MRG: update tests for distance metrics to test symmetry, with a bit of paranoia thrown in #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adamtaranto
added a commit
that referenced
this pull request
Sep 23, 2024
* Add rayon * add scipy for testing cosine * Init cosine() method to calc cosine similarity. Use rayon. * Add cosine() tests * jaccard tests * Jaccard Similarity Coefficient * Style fixes by Ruff * MRG: update tests for distance metrics to test symmetry, with a bit of paranoia thrown in (#48) * test symmetric * Style fixes by Ruff --------- Co-authored-by: ctb <[email protected]> --------- Co-authored-by: Adamtaranto <[email protected]> Co-authored-by: C. Titus Brown <[email protected]> Co-authored-by: ctb <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: PR into #45
This PR updates tests to be explicitly symmetric. It also avoids setting a missing k-mer count to 0 explicitly in one of the cos tests, so as test what happens when a k-mer is actually absent.
All minor changes but they make me feel a bit more secure :)