Do format updates on top of current commit rather than head. #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adamtaranto
added a commit
that referenced
this pull request
Sep 23, 2024
* Do format updates on top of current commit rather than head. (#46) * update serde_json version * switch to using built-in temp_path * write two additional tests * Style fixes by Ruff * clean up docstrings viz cargo doc --document-private-items --------- Co-authored-by: Adam Taranto <[email protected]> Co-authored-by: ctb <[email protected]>
Adamtaranto
added a commit
that referenced
this pull request
Sep 23, 2024
* Add toml package as testing dependency. * Add version attribute to new KmerCountTable instances. * Test version attribute. * Track total bases consumed with attr consumed * Add tests for consumed attr * Add sum_counts attr to get total counts in table. * Add tests for sum_counts attr * Add __len__ method to get total unique kmer count. * Add tests for __len__ method. * Add __getitem__ and __setitem__ methods * Tests for __getitem__ and __setitem__ dunder methods. * Make KmerCountTable iterable * Add tests for __iter__ * Add serde and flate2 * Add serialisation support * Add serialisation tests * Add niffler * sort imports * Use niffler for gzip read/write * Style fixes by Ruff * bump serde * MRG: update serialization code (#49) * Do format updates on top of current commit rather than head. (#46) * update serde_json version * switch to using built-in temp_path * write two additional tests * Style fixes by Ruff * clean up docstrings viz cargo doc --document-private-items --------- Co-authored-by: Adam Taranto <[email protected]> Co-authored-by: ctb <[email protected]> --------- Co-authored-by: Adamtaranto <[email protected]> Co-authored-by: C. Titus Brown <[email protected]> Co-authored-by: ctb <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ruff github action was checking out head of PR before making edits, this resulted in conflicts with the incoming commit if they edit the same python files.
See if checkout incoming commit fixes this.