Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(refactor): fix nullable parameters error in nightly failure #557

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

anon-pradip
Copy link
Contributor

This PR fixes nightly failures caused by Implicit nullable parameters issue
Related issue: owncloud/QA#859

@CLAassistant
Copy link

CLAassistant commented Aug 14, 2024

CLA assistant check
All committers have signed the CLA.

@anon-pradip anon-pradip force-pushed the test/fix-nightly-failures branch from 4fc632d to cdab9cd Compare August 14, 2024 06:23
@anon-pradip anon-pradip force-pushed the test/fix-nightly-failures branch 3 times, most recently from ce59c46 to 297bf4f Compare August 14, 2024 07:53
lib/Item.php Outdated Show resolved Hide resolved
@anon-pradip anon-pradip force-pushed the test/fix-nightly-failures branch 2 times, most recently from 51d6f85 to 19573df Compare August 14, 2024 08:47
lib/Item.php Outdated Show resolved Hide resolved
@anon-pradip anon-pradip force-pushed the test/fix-nightly-failures branch from 19573df to f8d0de6 Compare August 14, 2024 09:19
@phil-davis
Copy link
Contributor

@DeepDiver1975 @jnweiger GitHub tells me that I am not authorized to merge this PR.
I have merged PRs in other oC10 app repos, so I don't know what is special about this repo.

Can one of you merge please?

Copy link

@phil-davis
Copy link
Contributor

@DeepDiver1975 @jnweiger @micbar or anybody with privs.

I can't merge this. I don't know what privs I am missing for this repo. Can someone please merge it.

@DeepDiver1975 DeepDiver1975 merged commit 37b9106 into owncloud:master Aug 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants