Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QA] Fix nightly failures #859

Closed
9 tasks done
nirajacharya2 opened this issue Aug 14, 2024 · 2 comments
Closed
9 tasks done

[QA] Fix nightly failures #859

nirajacharya2 opened this issue Aug 14, 2024 · 2 comments
Assignees
Labels

Comments

@nirajacharya2
Copy link

nirajacharya2 commented Aug 14, 2024

New version of php is causing phan errors

lib/DocumentProperties.php:60 PhanDeprecatedImplicitNullableParam Implicit nullable parameters (string $fileName = null) have been deprecated in PHP 8.4
lib/context.php:203 PhanDeprecatedImplicitNullableParam Implicit nullable parameters (\Sabre\DAV\Server $sabreServer = null) have been deprecated in PHP 8.4
rules/filesize.php:51 PhanDeprecatedImplicitNullableParam Implicit nullable parameters (\Sabre\DAV\Server $sabreServer = null) have been deprecated in PHP 8.4
@phil-davis
Copy link
Contributor

phan is now checking for things that are deprecated in PHP 8.4.
It doesn't actually effect oC10, because that only supports PHP 7.4 at the moment.
But we may as well fix these, because it is easy to put a ? before each nullable parameter.

@PrajwolAmatya
Copy link

All related PRs have been merged and no issues is seen in CI. So, closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants