feat: add basic-auth credential tool #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g-linville
reviewed
Nov 22, 2024
basic-auth/main.go
Outdated
Comment on lines
120
to
122
| if env == "" { | ||
| env = strings.ToUpper(field) | ||
| } |
There was a problem hiding this comment.
To avoid any problems or unexpected results in the future, I think we should require environment variables to be specified, rather than just setting it to the field name by default.
There was a problem hiding this comment.
Good idea, I'll update this
njhale
force-pushed
the
feat/basic-auth-tool
branch
from
6929c0a to
2d62bb4
Compare
Add the `Basic Auth` tool to support collecting a username and password from a user. This is useful for interacting with platforms with no or limited OAuth support. Signed-off-by: Nick Hale <[email protected]>
njhale
force-pushed
the
feat/basic-auth-tool
branch
from
2d62bb4 to
33e3b13
Compare
njhale
requested review from
g-linville,
drpebcak,
thedadams,
StrongMonkey and
ryanhopperlowe
g-linville
approved these changes
Nov 25, 2024
drpebcak
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the
Basic Authtool to support collecting a username and password from a user. This is useful for interacting with platforms with no or limited OAuth support.This is required to make authenticated requests with App Passwords in the Bluesky tools, since seems like extending Otto8 to meet Bluesky's additional OAuth requirements appears to be non-trivial (see their docs on client metadata and token requests for additional requirements; e.g. DPoP-bound access tokens).
Note:
This tool requires generic prompts in Otto8 before it can merge. I'm implementing that now.Ryan implemented prompting in the UI for basic cred tools in otto8-ai/otto8#665