fix: bluesky time-bound query issues #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njhale
force-pushed
the
fix/bsky-search
branch
from
b2d5e70 to
eb5876c
Compare
|
|
njhale
requested review from
drpebcak,
thedadams,
StrongMonkey,
iwilltry42,
ryanhopperlowe and
g-linville
StrongMonkey
approved these changes
Nov 25, 2024
The `Bluesky` bundle's `Search Post` tool fails to search for posts when the `since` or `until` parameters are set due an error returned by the public bsky search APIs. This isn't well documented, but after some testing it was determined that this only occurs when making unauthenticated requests. To fix this issue, this change updates the Bluesky tools to make authenticated requests with a user handle and [App Password](https://bsky.app/settings/app-passwords) provided by the user via a basic auth credential tool. This change also exposes a `tags` parameter on the `Search Post` tool to make it easier for agents to search by tag. Signed-off-by: Nick Hale <[email protected]>
njhale
force-pushed
the
fix/bsky-search
branch
from
eb5876c to
cb80ba4
Compare
iwilltry42
approved these changes
Nov 25, 2024
drpebcak
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Blueskybundle'sSearch Posttool fails to search for posts when thesinceoruntilparameters are set due an error returned by the public bsky search APIs. This isn't well documented, but after some testing it was determined that this only occurs when makingunauthenticated requests.
To fix this issue, this change updates the Bluesky tools to make authenticated requests with a user handle and App Password provided by the user via a basic auth credential tool.
This change also exposes a
tagsparameter on theSearch Posttool to make it easier for agents to search by tag.Note: This PR depends on #228