main: Also automatically remount rw /sysroot for ostree pull etc.
#2027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgwalters
force-pushed
the
pull-auto-mnt-namespace
branch
from
229ddad to
2749887
Compare
cgwalters
changed the title
ostree pull etc.ostree pull etc.
|
Lifted WIP, this is tested and working. |
|
Can we do #2029 first? That way we can be sure that the same kola tests that previously failed now pass. |
|
Patch looks reasonable to me otherwise! |
See coreos/fedora-coreos-tracker#343 When we added the read-only sysroot support it broke using "raw" `ostree pull` and `ostree refs --create` and all of the core repo CLIs that just operate on a repo and not a sysroot. Fixing this is a bit ugly as it "layer crosses" things even more. Extract a helper function that works in both cases.
cgwalters
force-pushed
the
pull-auto-mnt-namespace
branch
from
2749887 to
6a27dff
Compare
|
Nice, ostree failures are now passing! Though hmm, looks like |
|
The problem is now interlock with coreos/rpm-ostree#2015 |
|
Right, it would need the new rpm-ostree to pass. Anyway, I've confirmed locally that this patch + git master rpm-ostree is green: /override continuous-integration/jenkins/pr-merge |
|
@jlebon: Overrode contexts on behalf of jlebon: continuous-integration/jenkins/pr-merge In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, jlebon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See coreos/fedora-coreos-tracker#343
When we added the read-only sysroot support it broke using "raw"
ostree pullandostree refs --createand all of the core repoCLIs that just operate on a repo and not a sysroot.
Fixing this is a bit ugly as it "layer crosses" things even more.
Extract a helper function that works in both cases.