-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build-sys: Hard require libostree 2020.1 #2015
build-sys: Hard require libostree 2020.1 #2015
Conversation
/lgtm I took the liberty of pushing another commit here so that we stop using FAHC, which was causing us to still pull in old libostree and break compilation. If you have review comments on that commit, feel free to |
OK we have a deadlock now:
Hmm. OK so we can probably unbreak this by overriding ostree in this repo. |
The current `rpm-ostree-2020.1-1.fc31.x86_64` in Fedora was [built with a truly ancient libostree](https://kojipkgs.fedoraproject.org//packages/rpm-ostree/2020.1/1.fc31/data/logs/x86_64/root.log) because Fedora's build system is weird and only adds packages released after "gold" into the buildroot via an override that times out. This actively breaks things because rpm-ostree isn't detecting the read-only sysroot. Let's bump our hard requirement.
11bc82e
to
51c675e
Compare
FAHC is super out of date now. The way to have access to newer packages is via the continuous tag, which is still manual for now, but at least targets the right Fedora release.
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, jlebon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, jlebon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
OK cool, this is now hitting |
/override continuous-integration/jenkins/pr-merge |
@cgwalters: Overrode contexts on behalf of cgwalters: continuous-integration/jenkins/pr-merge In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The current
rpm-ostree-2020.1-1.fc31.x86_64
in Fedorawas built with a truly ancient libostree
because Fedora's build system is weird and only adds packages
released after "gold" into the buildroot via an override
that times out.
This actively breaks things because rpm-ostree isn't
detecting the read-only sysroot.
Let's bump our hard requirement.