Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build-sys: Hard require libostree 2020.1 #2015

Merged
merged 2 commits into from
Mar 13, 2020

Conversation

cgwalters
Copy link
Member

The current rpm-ostree-2020.1-1.fc31.x86_64 in Fedora
was built with a truly ancient libostree
because Fedora's build system is weird and only adds packages
released after "gold" into the buildroot via an override
that times out.

This actively breaks things because rpm-ostree isn't
detecting the read-only sysroot.

Let's bump our hard requirement.

@jlebon
Copy link
Member

jlebon commented Mar 13, 2020

/lgtm

I took the liberty of pushing another commit here so that we stop using FAHC, which was causing us to still pull in old libostree and break compilation.

If you have review comments on that commit, feel free to /hold it!

@cgwalters
Copy link
Member Author

OK we have a deadlock now:

Resolving dependencies... done
error: Could not depsolve transaction; 1 problem detected:
 Problem: package rpm-ostree-2020.1.37.g11bc82ea-1.fc31.x86_64 requires libostree-1.so.1(LIBOSTREE_2020.1)(64bit), but none of the providers can be installed
  - conflicting requests
  - package ostree-libs-2020.2-2.fc31.x86_64 is filtered out by exclude filtering

Hmm. OK so we can probably unbreak this by overriding ostree in this repo.

The current `rpm-ostree-2020.1-1.fc31.x86_64` in Fedora
was [built with a truly ancient libostree](https://kojipkgs.fedoraproject.org//packages/rpm-ostree/2020.1/1.fc31/data/logs/x86_64/root.log)
because Fedora's build system is weird and only adds packages
released after "gold" into the buildroot via an override
that times out.

This actively breaks things because rpm-ostree isn't
detecting the read-only sysroot.

Let's bump our hard requirement.
FAHC is super out of date now. The way to have access to newer packages
is via the continuous tag, which is still manual for now, but at least
targets the right Fedora release.
@jlebon
Copy link
Member

jlebon commented Mar 13, 2020

/lgtm

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, jlebon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, jlebon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jlebon
Copy link
Member

jlebon commented Mar 13, 2020

OK cool, this is now hitting EROFS, which is a good sign because it means that it's actually using the latest libostree. So we'll need ostreedev/ostree#2027 first.

@cgwalters
Copy link
Member Author

/override continuous-integration/jenkins/pr-merge
because we know this is good. Now just needs a lgtm.

@openshift-ci-robot
Copy link
Collaborator

@cgwalters: Overrode contexts on behalf of cgwalters: continuous-integration/jenkins/pr-merge

In response to this:

/override continuous-integration/jenkins/pr-merge
because we know this is good. Now just needs a lgtm.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit e6907d2 into coreos:master Mar 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants