This repository has been archived by the owner on Nov 7, 2024. It is now read-only.
Fix digest usage #666
Merged
Fix digest usage #666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In other words this one should be a big red flag in code - it's never right to just ignore the algorithm. What's the most common though is a pattern like:
We could look at adding a helper for that. |
In some places we started doing `.digest().digest()` which drops the algorithm. Some basic unit tests would have caught this - I added one. We also need an "upgrade from previous" test. Trying to fix this revealed a bunch more places where we had `String` and not `Digest`. Fixing those gets us type safety and points out the problem areas. Since we're breaking API as this will be the real first 0.15 release, - Drop unnecessary ManifestLayerState wrappering - Fix the manifest digest members of various structs to be a Digest
cgwalters
force-pushed
the
fix-digest-traps
branch
from
e9cc88e to
c0bc636
Compare
jeckersb
approved these changes
Sep 24, 2024
| use super::*; | ||
|
|
||
| #[test] | ||
| fn test_ref_for_descriptor() { |
| @@ -21,7 +21,7 @@ use flate2::Compression; | |||
| use fn_error_context::context; | |||
| use futures_util::TryFutureExt; | |||
| use oci_spec::image::{ | |||
| self as oci_image, Arch, Descriptor, History, ImageConfiguration, ImageManifest, | |||
| self as oci_image, Arch, Descriptor, Digest, History, ImageConfiguration, ImageManifest, | |||
There was a problem hiding this comment.
We still use oci_image::Digest in a bunch of places, not a big deal but I can do a followup PR after this merges just so we're consistent everywhere.
|
Obligatory acknowledgement that the bootc build test is failing because we need to do the CI dance to get both updated in-tandem. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some places we started doing
.digest().digest()which drops the algorithm. Some basic unit testswould have caught this - I added one. We also need an "upgrade from previous" test.
Trying to fix this revealed a bunch more places where we had
Stringand notDigest.Fixing those gets us type safety and points out the problem areas. Since we're breaking API as this will be the real first 0.15 release,