Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#650 issue: updated all the steepness values to 1 #673

Closed

Conversation

hashoak
Copy link

@hashoak hashoak commented Jun 9, 2023

Have changed all the steepness values to 1 as said in the comments for the variable steepness => "Control the wave steepness. 0 is sine waves, 1 is Gerstner waves."

@hashoak hashoak changed the title #650 issue: updated all the steepness to 1 #650 issue: updated all the steepness values to 1 Jun 9, 2023
@M1chaelM
Copy link
Collaborator

Thanks for this contribution! My apologies, but I'm afraid the issue you addressed was a bit underspecified--we were discussing it internally and I didn't expect a community member to take it on so quickly. In attempting to test it, we discovered another issue with steepness that is causing us to postpone changes to this value for now. I've written this up in issue #683 (which I hope is more clear than what I wrote for #650).If you're interested in digging into this, we'd certainly welcome help investigating!

In the meantime I will close this PR since I don't anticipate wanting to set all steepness values to 1.

@M1chaelM M1chaelM closed this Jun 27, 2023
@hashoak hashoak deleted the Issue#650-steepness-values-updated-to-1 branch June 29, 2023 09:02
@hashoak hashoak restored the Issue#650-steepness-values-updated-to-1 branch June 29, 2023 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants