Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set Waves to a Non-zero steepness #650

Closed
M1chaelM opened this issue May 17, 2023 · 1 comment
Closed

Set Waves to a Non-zero steepness #650

M1chaelM opened this issue May 17, 2023 · 1 comment
Assignees
@tejalbarnwal
Labels
good first issue Good for newcomers minor
Milestone
2.3.0

Comments

@M1chaelM
Copy link
Collaborator

Our wave model uses trochoidal waves but we currently have the steepness set to zero in all worlds, which collapses the shape to a sinusoid. If possible we should update this value to something that makes the trochoidal shape a little more evident.
@M1chaelM M1chaelM added this to the 2.3.0 milestone May 17, 2023
@M1chaelM M1chaelM self-assigned this May 23, 2023
@M1chaelM M1chaelM added good first issue Good for newcomers minor labels May 23, 2023
@M1chaelM M1chaelM assigned tejalbarnwal and unassigned M1chaelM May 23, 2023
hashoak added a commit to hashoak/vrx that referenced this issue Jun 9, 2023
@hashoak
osrf#650 issue: updated all the steepness to 1 (0 is sine waves, 1 is…
616eeef 
… Gerstner waves)
@tejalbarnwal tejalbarnwal mentioned this issue Jun 10, 2023
Closed
2 tasks
@M1chaelM
Copy link
Collaborator Author

Per discussion in #674 it seems that updating the steepness does not have any discernible effect on the wave rendering, and no one is sure why this is the case. Consequently, we don't need to update the values right now, and I will close this issue. Since this situation isn't urgent but also not ideal, I'll make a new issue to document the problem.

This was referenced Jun 26, 2023
Open
Closed
@M1chaelM M1chaelM reopened this Jun 27, 2023
@M1chaelM M1chaelM closed this as not planned Won't fix, can't repro, duplicate, stale Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tejalbarnwal tejalbarnwal

Labels
good first issue Good for newcomers minor
Projects
None yet
Milestone
2.3.0
Development

No branches or pull requests
2 participants
@M1chaelM @tejalbarnwal