Ros2 chapter #15
Merged
Ros2 chapter #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g, lost headings.
… intro section to top.
codebot
approved these changes
Jun 17, 2020
There was a problem hiding this comment.
I pushed a few trivial edits onto this branch, just fixing little typos. I think this is great. The main change (to be resolved later, after the merge, in a different PR, no need to hold it up now) is that we'll need the instructions to refer to ROS 2 Foxy because of other dependencies that require us to use Ubuntu 20.04, which means ROS 2 Foxy. Merging this as-is seems great to me. Thanks for all this work!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am going to submit a PR on this but the CLI and API sections arent done yet. I think I stopped at parameters. There is material there about params and rosbags but it is from an old talk. Can someone review this overnight and we'll pick it back up in the AM?
@codebot @mdfesto take a look and comment.