Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use REP103 SI units convention #98

Draft
wants to merge 47 commits into
base: main
Choose a base branch
from

Conversation

andermi
Copy link
Collaborator

@andermi andermi commented Oct 3, 2022

Address #84

  • PolytropicPneumaticSpring
  • ElectroHydraulicPTO
  • XbowAHRS
  • PowerController
  • SpringController

requires osrf/mbari_wec_utils#34

andermi and others added 30 commits August 23, 2022 17:49
Signed-off-by: Michael Anderson <[email protected]>
Signed-off-by: Michael Anderson <[email protected]>
Signed-off-by: Michael Anderson <[email protected]>
Signed-off-by: Michael Anderson <[email protected]>
Signed-off-by: Michael Anderson <[email protected]>
Signed-off-by: Michael Anderson <[email protected]>
…ets on physical test bench to be compared to simulation results. At the moment ElectroHydrauclicPTO does not seem to be working correctly, not reporting sensible RPM, etc.w
…ults to test machine data. Issue with ElectroHydraulicPTO not creating all entities in the first iteration.
…start with "EXP_" so plots won't be triggered if CI tries to run this test
…rface for ElectroHydraulicState

Signed-off-by: Michael Anderson <[email protected]>
… into hamilton8415/testmachinecompare

Signed-off-by: Michael Anderson <[email protected]>
andermi and others added 17 commits September 27, 2022 18:58
Signed-off-by: Michael Anderson <[email protected]>
Signed-off-by: Michael Anderson <[email protected]>
Signed-off-by: Michael Anderson <[email protected]>
Signed-off-by: Michael Anderson <[email protected]>
Signed-off-by: Michael Anderson <[email protected]>
@andermi andermi changed the base branch from main to andermi/test_machine_spring October 3, 2022 22:48
@andermi andermi linked an issue Oct 3, 2022 that may be closed by this pull request
5 tasks
Base automatically changed from andermi/test_machine_spring to main October 5, 2022 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use REP103 SI Units/Convention
3 participants